[GitHub] [spark] HeartSaVioR edited a comment on pull request #31638: [SPARK-34526][SS] Skip checking glob path in FileStreamSink.hasMetadata

2021-04-01 Thread GitBox
HeartSaVioR edited a comment on pull request #31638: URL: https://github.com/apache/spark/pull/31638#issuecomment-812224204 I guess we still don't decide with the following: > Just a one thing I think we'd like to make clear is, the flag on behavior. As we are sure we are fixing regr

[GitHub] [spark] HeartSaVioR edited a comment on pull request #31638: [SPARK-34526][SS] Skip checking glob path in FileStreamSink.hasMetadata

2021-03-26 Thread GitBox
HeartSaVioR edited a comment on pull request #31638: URL: https://github.com/apache/spark/pull/31638#issuecomment-808613061 OK I agree with the direction on setting goal as fixing "regression" only if we have no clear solution to fix the root cause or overall problem. Just a one thi

[GitHub] [spark] HeartSaVioR edited a comment on pull request #31638: [SPARK-34526][SS] Skip checking glob path in FileStreamSink.hasMetadata

2021-03-26 Thread GitBox
HeartSaVioR edited a comment on pull request #31638: URL: https://github.com/apache/spark/pull/31638#issuecomment-808072941 The glob path is valid for the path of data source, but I'm not sure I can agree it's also valid for the parameter of `FileStreamSink.hasMetadata()`. I couldn't