[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1223661427 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java: ## @@ -30,12 +30,12 @@ * An {@link Identifier} implementation. */ @Evol

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1222869265 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala: ## @@ -194,12 +203,30 @@ class V2SessionCatalog(catalog: SessionCatalo

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1222862287 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala: ## @@ -194,12 +203,30 @@ class V2SessionCatalog(catalog: SessionCatalo

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1222860848 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/connector/IdentifierImpl.scala: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1221302284 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala: ## @@ -194,12 +203,28 @@ class V2SessionCatalog(catalog: SessionCatalo

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1221277562 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -849,6 +849,7 @@ class SessionCatalog( tempViews.remove(table

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1221129625 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -849,6 +849,7 @@ class SessionCatalog( tempViews.remove(table

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1212912891 ## sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala: ## @@ -1072,6 +1072,8 @@ class HiveDDLSuite } test("drop view using drop tab

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1212891923 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala: ## @@ -71,7 +71,12 @@ class V2SessionCatalog(catalog: SessionCatalog)

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1211614022 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java: ## @@ -30,12 +30,12 @@ * An {@link Identifier} implementation. */ @Evol

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1211613665 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala: ## @@ -691,22 +691,24 @@ class PlanResolutionSuite extends AnalysisTest {

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2

Hisoka-X commented on code in PR #41348: URL: https://github.com/apache/spark/pull/41348#discussion_r1208726693 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java: ## @@ -30,12 +30,12 @@ * An {@link Identifier} implementation. */ @Evol