[GitHub] [spark] Hisoka-X commented on a diff in pull request #42802: [SPARK-43752][SQL] Support default column value on DataSource V2

Hisoka-X commented on code in PR #42802: URL: https://github.com/apache/spark/pull/42802#discussion_r1326897921 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -139,8 +141,32 @@ class BasicInMemoryTableCatalog extends Table

[GitHub] [spark] Hisoka-X commented on a diff in pull request #42802: [SPARK-43752][SQL] Support default column value on DataSource V2

Hisoka-X commented on code in PR #42802: URL: https://github.com/apache/spark/pull/42802#discussion_r1314901375 ## sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala: ## @@ -1758,169 +1095,6 @@ class InsertSuite extends DataSourceTest with SharedSparkSession

[GitHub] [spark] Hisoka-X commented on a diff in pull request #42802: [SPARK-43752][SQL] Support default column value on DataSource V2

Hisoka-X commented on code in PR #42802: URL: https://github.com/apache/spark/pull/42802#discussion_r1315341345 ## sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala: ## @@ -997,669 +997,6 @@ class InsertSuite extends DataSourceTest with SharedSparkSession {

[GitHub] [spark] Hisoka-X commented on a diff in pull request #42802: [SPARK-43752][SQL] Support default column value on DataSource V2

Hisoka-X commented on code in PR #42802: URL: https://github.com/apache/spark/pull/42802#discussion_r1314885709 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/V2WriteAnalysisSuite.scala: ## @@ -477,21 +477,6 @@ abstract class V2WriteAnalysisSuiteBase exten

[GitHub] [spark] Hisoka-X commented on a diff in pull request #42802: [SPARK-43752][SQL] Support default column value on DataSource V2

Hisoka-X commented on code in PR #42802: URL: https://github.com/apache/spark/pull/42802#discussion_r1314885709 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/V2WriteAnalysisSuite.scala: ## @@ -477,21 +477,6 @@ abstract class V2WriteAnalysisSuiteBase exten