HyukjinKwon commented on a change in pull request #28032:
URL: https://github.com/apache/spark/pull/28032#discussion_r650449381



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -221,6 +221,46 @@ object DataSourceAnalysis extends Rule[LogicalPlan] with 
CastSupport {
   }
 }
 
+/**
+ * Add a repartition by dynamic partition columns before insert Datasource 
table.
+ *
+ * Note that, this rule must be run after `DataSourceAnalysis`.

Review comment:
       That's fine but it would be great to explain here in a comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to