[GitHub] [spark] HyukjinKwon commented on a change in pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
HyukjinKwon commented on a change in pull request #28387: URL: https://github.com/apache/spark/pull/28387#discussion_r416429707 ## File path: R/pkg/R/DataFrame.R ## @@ -1226,8 +1226,7 @@ setMethod("collect", # empty data.frame with 0 columns and 0 rows

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28387: [SPARK-29339][R][FOLLOW-UP] remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
HyukjinKwon commented on a change in pull request #28387: URL: https://github.com/apache/spark/pull/28387#discussion_r416431223 ## File path: R/pkg/R/DataFrame.R ## @@ -1226,8 +1226,7 @@ setMethod("collect", # empty data.frame with 0 columns and 0 rows

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28387: [SPARK-29339][R][FOLLOW-UP] Remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
HyukjinKwon commented on a change in pull request #28387: URL: https://github.com/apache/spark/pull/28387#discussion_r416548957 ## File path: R/pkg/R/types.R ## @@ -88,11 +88,6 @@ specialtypeshandle <- function(type) { checkSchemaInArrow <- function(schema) { stopifnot(inhe

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28387: [SPARK-29339][R][FOLLOW-UP] Remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
HyukjinKwon commented on a change in pull request #28387: URL: https://github.com/apache/spark/pull/28387#discussion_r416551145 ## File path: R/pkg/R/utils.R ## @@ -930,3 +930,7 @@ getOne <- function(x, envir, inherits = TRUE, ifnotfound = NULL) { traverseParentDirs <- functi