[GitHub] [spark] HyukjinKwon commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-21 Thread GitBox
HyukjinKwon commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429034529 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala ## @@ -337,11 +340,19 @@ trait DivModLike

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-21 Thread GitBox
HyukjinKwon commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r428991924 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala ## @@ -337,11 +340,19 @@ trait DivModLike

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-21 Thread GitBox
HyukjinKwon commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r428991160 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala ## @@ -505,4 +505,9 @@ class