[GitHub] [spark] HyukjinKwon commented on a change in pull request #30501: [SPARK-33563][PYTHON][R][SQL] Expose inverse hyperbolic trig functions in PySpark and SparkR

2020-11-25 Thread GitBox
HyukjinKwon commented on a change in pull request #30501: URL: https://github.com/apache/spark/pull/30501#discussion_r530719552 ## File path: python/pyspark/sql/functions.py ## @@ -220,6 +220,19 @@ def acos(col): return _invoke_function_over_column("acos", col) +def

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30501: [SPARK-33563][PYTHON][R][SQL] Expose inverse hyperbolic trig functions in PySpark and SparkR

2020-11-25 Thread GitBox
HyukjinKwon commented on a change in pull request #30501: URL: https://github.com/apache/spark/pull/30501#discussion_r530719331 ## File path: R/pkg/R/functions.R ## @@ -455,6 +455,19 @@ setMethod("acos", column(jc) }) +#' @details Review comment: