HyukjinKwon commented on code in PR #38302: URL: https://github.com/apache/spark/pull/38302#discussion_r1028906041
########## sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala: ########## @@ -56,7 +56,10 @@ case class SparkListenerSQLExecutionStart( } @DeveloperApi -case class SparkListenerSQLExecutionEnd(executionId: Long, time: Long) +case class SparkListenerSQLExecutionEnd( + executionId: Long, + time: Long, + errorMessage: Option[String] = None) Review Comment: Doesn't this break binary compatibility? I think it should have overridden constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
