[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38546: [SPARK-41036][CONNECT][PYTHON] `columns` API should use `schema` API to avoid data fetching

2022-11-10 Thread GitBox
HyukjinKwon commented on code in PR #38546: URL: https://github.com/apache/spark/pull/38546#discussion_r1018829248 ## python/pyspark/sql/connect/dataframe.py: ## @@ -139,11 +139,9 @@ def columns(self) -> List[str]: if self._plan is None: return []

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38546: [SPARK-41036][CONNECT][PYTHON] `columns` API should use `schema` API to avoid data fetching

2022-11-10 Thread GitBox
HyukjinKwon commented on code in PR #38546: URL: https://github.com/apache/spark/pull/38546#discussion_r1018827390 ## python/pyspark/sql/connect/dataframe.py: ## @@ -139,11 +139,9 @@ def columns(self) -> List[str]: if self._plan is None: return []

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38546: [SPARK-41036][CONNECT][PYTHON] `columns` API should use `schema` API to avoid data fetching

2022-11-09 Thread GitBox
HyukjinKwon commented on code in PR #38546: URL: https://github.com/apache/spark/pull/38546#discussion_r1018707453 ## python/pyspark/sql/connect/dataframe.py: ## @@ -139,11 +139,9 @@ def columns(self) -> List[str]: if self._plan is None: return []

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38546: [SPARK-41036][CONNECT][PYTHON] `columns` API should use `schema` API to avoid data fetching

2022-11-09 Thread GitBox
HyukjinKwon commented on code in PR #38546: URL: https://github.com/apache/spark/pull/38546#discussion_r1018707212 ## python/pyspark/sql/connect/dataframe.py: ## @@ -139,11 +139,9 @@ def columns(self) -> List[str]: if self._plan is None: return []