HyukjinKwon commented on code in PR #38947: URL: https://github.com/apache/spark/pull/38947#discussion_r1041690900
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala: ########## @@ -119,21 +117,24 @@ case class Size(child: Expression, legacySizeOfNull: Boolean) val value = child.eval(input) if (value == null) { if (legacySizeOfNull) -1 else null - } else child.dataType match { - case _: ArrayType => value.asInstanceOf[ArrayData].numElements() - case _: MapType => value.asInstanceOf[MapData].numElements() - case other => throw QueryExecutionErrors.unsupportedOperandTypeForSizeFunctionError(other) - } + } else Review Comment: Can we remove unrelated style changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org