[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-03-23 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1146129611 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala: ## @@ -53,19 +59,37 @@ class SparkConnectService(debug: B

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-03-22 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1145632881 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala: ## @@ -53,19 +59,37 @@ class SparkConnectService(debug: B

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-09 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1102174832 ## python/pyspark/errors/exceptions/connect.py: ## @@ -61,41 +97,34 @@ class AnalysisException(SparkConnectGrpcException, BaseAnalysisException): Failed to an

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-09 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1102138582 ## python/pyspark/errors/exceptions/connect.py: ## @@ -61,41 +97,34 @@ class AnalysisException(SparkConnectGrpcException, BaseAnalysisException): Failed to an

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-09 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1102138305 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala: ## @@ -83,27 +107,19 @@ class SparkConnectService(debug:

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-09 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1101440253 ## python/pyspark/sql/tests/pandas/test_pandas_udf.py: ## @@ -171,7 +171,7 @@ def test_stopiteration_in_udf(self): def foo(x): raise StopItera

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-09 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1101386854 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala: ## @@ -53,19 +59,36 @@ class SparkConnectService(debug: B

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-09 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1101374445 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala: ## @@ -53,19 +59,36 @@ class SparkConnectService(debug: B

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-08 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1101076905 ## python/pyspark/errors/exceptions/connect.py: ## @@ -61,41 +97,34 @@ class AnalysisException(SparkConnectGrpcException, BaseAnalysisException): Failed to an

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-08 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1101075312 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala: ## @@ -83,27 +107,19 @@ class SparkConnectService(debug:

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-08 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1101075312 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala: ## @@ -83,27 +107,19 @@ class SparkConnectService(debug:

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-08 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1100994819 ## python/pyspark/errors/exceptions/connect.py: ## @@ -61,41 +97,34 @@ class AnalysisException(SparkConnectGrpcException, BaseAnalysisException): Failed to an

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39947: [SPARK-40453][SPARK-41715][CONNECT] Take super class into account when throwing an exception

2023-02-08 Thread via GitHub
HyukjinKwon commented on code in PR #39947: URL: https://github.com/apache/spark/pull/39947#discussion_r1100994134 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala: ## @@ -53,19 +59,37 @@ class SparkConnectService(debug: B