[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42513: [SPARK-44827][PYTHON][TESTS] Fix test when ansi mode enabled

2023-08-20 Thread via GitHub
HyukjinKwon commented on code in PR #42513: URL: https://github.com/apache/spark/pull/42513#discussion_r1299463703 ## python/pyspark/sql/dataframe.py: ## @@ -3793,6 +3793,8 @@ def union(self, other: "DataFrame") -> "DataFrame": Example 2: Combining two DataFrames with d

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42513: [SPARK-44827][PYTHON][TESTS] Fix test when ansi mode enabled

2023-08-22 Thread via GitHub
HyukjinKwon commented on code in PR #42513: URL: https://github.com/apache/spark/pull/42513#discussion_r1302313324 ## python/pyspark/sql/dataframe.py: ## @@ -3912,16 +3912,29 @@ def union(self, other: "DataFrame") -> "DataFrame": >>> df2 = spark.createDataFrame([(3, "Ch

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42513: [SPARK-44827][PYTHON][TESTS] Fix test when ansi mode enabled

2023-08-22 Thread via GitHub
HyukjinKwon commented on code in PR #42513: URL: https://github.com/apache/spark/pull/42513#discussion_r1302314087 ## python/pyspark/sql/functions.py: ## @@ -7802,8 +7802,20 @@ def to_unix_timestamp( >>> spark.conf.set("spark.sql.session.timeZone", "America/Los_Angeles")

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42513: [SPARK-44827][PYTHON][TESTS] Fix test when ansi mode enabled

2023-08-22 Thread via GitHub
HyukjinKwon commented on code in PR #42513: URL: https://github.com/apache/spark/pull/42513#discussion_r1302314216 ## python/pyspark/testing/utils.py: ## @@ -411,8 +412,8 @@ def assertDataFrameEqual( Note that schema equality is checked only when `expected` is a DataFrame

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42513: [SPARK-44827][PYTHON][TESTS] Fix test when ansi mode enabled

2023-08-22 Thread via GitHub
HyukjinKwon commented on code in PR #42513: URL: https://github.com/apache/spark/pull/42513#discussion_r1302314334 ## python/pyspark/testing/utils.py: ## @@ -539,6 +540,9 @@ def compare_vals(val1, val2): elif isinstance(val1, float) and isinstance(val2, float):

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42513: [SPARK-44827][PYTHON][TESTS] Fix test when ansi mode enabled

2023-08-23 Thread via GitHub
HyukjinKwon commented on code in PR #42513: URL: https://github.com/apache/spark/pull/42513#discussion_r1302846694 ## python/pyspark/sql/dataframe.py: ## @@ -3908,8 +3908,21 @@ def union(self, other: "DataFrame") -> "DataFrame": Example 2: Combining two DataFrames with