[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42541: [SPARK-44854][PYTHON] Python timedelta to DayTimeIntervalType edge case bug

2023-08-21 Thread via GitHub
HyukjinKwon commented on code in PR #42541: URL: https://github.com/apache/spark/pull/42541#discussion_r1300849673 ## python/pyspark/sql/types.py: ## @@ -442,7 +442,7 @@ def needConversion(self) -> bool: def toInternal(self, dt: datetime.timedelta) -> Optional[int]:

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42541: Spark 44854

2023-08-20 Thread via GitHub
HyukjinKwon commented on code in PR #42541: URL: https://github.com/apache/spark/pull/42541#discussion_r1299534962 ## python/pyspark/sql/types.py: ## @@ -442,7 +442,7 @@ def needConversion(self) -> bool: def toInternal(self, dt: datetime.timedelta) -> Optional[int]:

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42541: Spark 44854

2023-08-20 Thread via GitHub
HyukjinKwon commented on code in PR #42541: URL: https://github.com/apache/spark/pull/42541#discussion_r1299533479 ## python/pyspark/sql/types.py: ## @@ -442,7 +442,7 @@ def needConversion(self) -> bool: def toInternal(self, dt: datetime.timedelta) -> Optional[int]: