subject:"\[GitHub\] \[spark\] HyukjinKwon commented on a diff in pull request #42929\: \[SPARK\-45167\]\[CONNECT\] Python client must call `release_all`"

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42929: [SPARK-45167][CONNECT] Python client must call `release_all`

2023-09-15 Thread via GitHub

HyukjinKwon commented on code in PR #42929: URL: https://github.com/apache/spark/pull/42929#discussion_r1327072112 ## python/pyspark/sql/connect/client/reattach.py: ## @@ -14,14 +14,16 @@ # See the License for the specific language governing permissions and # limitations

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42929: [SPARK-45167][CONNECT] Python client must call `release_all`

2023-09-15 Thread via GitHub

HyukjinKwon commented on code in PR #42929: URL: https://github.com/apache/spark/pull/42929#discussion_r1326864836 ## python/pyspark/sql/tests/connect/client/test_client.py: ## @@ -147,15 +150,33 @@ def _stub_with(self, execute=None, attach=None):