[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-499397145 ok to test This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-06 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-499397202 retest this please This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-03 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-498285463 WDYT guys? I think current approach makes sense and consistent with some expressions we have.

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-03 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-498239043 retest this please This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-03 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-498199928 retest this please This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-06-03 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-498129980 retest this please This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-05-23 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-495458702 cc @cloud-fan too This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-05-21 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-494419424 Reynold, @rxin, does this (https://github.com/apache/spark/pull/24335#issuecomment-494086108) answer to your question?

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-05-21 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-494419306 retest this please This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-05-20 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-494248222 retest this please This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-05-20 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-494234508 okie. can you rebase? This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

2019-05-20 Thread GitBox
HyukjinKwon commented on issue #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#issuecomment-493895297 Then I guess it's fine to add `count_if` alone. Is the name `count_if` prevailing or `countif` per