HyukjinKwon commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS]
Convert and port 'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25161#issuecomment-514488233
Merged to master.
T
HyukjinKwon commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS]
Convert and port 'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25161#issuecomment-514436080
retest this please
HyukjinKwon commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS]
Convert and port 'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25161#issuecomment-513676338
Thanks for updating and addressing comments. Looks fine. Let me take a final
look ag
HyukjinKwon commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS]
Convert and port 'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25161#issuecomment-513618271
@shivusondur, is the diff correct? Looks weird:
```diff
diff --git
a/sql/c
HyukjinKwon commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS]
Convert and port 'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25161#issuecomment-513123925
retest this please
HyukjinKwon commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS]
Convert and port 'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25161#issuecomment-512657512
Looks fine otherwise if the tests pass
-
HyukjinKwon commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS]
Convert and port 'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25161#issuecomment-51265
#25130 is merged. Can you rebase and update it against the current master?
-
HyukjinKwon commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS]
Convert and port 'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25161#issuecomment-512656636
ok to test
This is
HyukjinKwon commented on issue #25161: [SPARK-28390][SQL][PYTHON][TESTS]
Convert and port 'pgSQL/select_having.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25161#issuecomment-511445396
PR description isn't exactly guided. It should be foldable with
html tag.