[GitHub] [spark] HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into UDF test base

2019-07-25 Thread GitBox
HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into UDF test base URL: https://github.com/apache/spark/pull/25195#issuecomment-515044544 Merged to master. Thanks @younggyuchun. Wellcome to Spark contributors :D.

[GitHub] [spark] HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into UDF test base

2019-07-24 Thread GitBox
HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into UDF test base URL: https://github.com/apache/spark/pull/25195#issuecomment-514860931 Thanks, @younggyuchun. Do you mind updating PR description (the diff) too?

[GitHub] [spark] HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into UDF test base

2019-07-21 Thread GitBox
HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into UDF test base URL: https://github.com/apache/spark/pull/25195#issuecomment-513619192 Yup, let's put it back. This is

[GitHub] [spark] HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513080850 Can you elaborate why and confirm if Scala UDF works or not as well? We should better match the test cases

[GitHub] [spark] HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513076671 @younggyuchun, do you know why it works with UDFs? ``` -- !query 19 -SELECT val, cate,

[GitHub] [spark] HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513058045 add to whitelist This is an automated

[GitHub] [spark] HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513058024 Add to whitelist This is an automated

[GitHub] [spark] HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513057962 ok to test This is an automated message