HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-714911468
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-714359495
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-714286400
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-711656428
Let me merge this in few days if there are no more comments assuming lazy
consensus.
This is an automated
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-700349606
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-699610093
@Ngone51, shall we add a test
https://github.com/apache/spark/pull/29817#issuecomment-698438316 and fix the
test as requested? Seems like otherwise good to go.
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-698062962
> but that's only half true, this PR just broke the test some more.
@holdenk, you're kidding right? There was only one test failure that was not
caused by this PR in
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-696492521
@holdenk, why don't you take a look for a test failure since it blocks all
changes in decommission in k8s, and you were involved mainly in the development
there?
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-696492521
@holdenk, why don't you take a look for a test failure since it blocks all
changes in decommission in k8s, and you were involved mainly in the development
there?
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-696106376
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-696136507
Got it about -1 but what about we pushing this as is, and work on the test
as followups? It's a bit odds that we reverted it for the reason this PR didn't
cause, and ask
HyukjinKwon commented on pull request #29817:
URL: https://github.com/apache/spark/pull/29817#issuecomment-696106376
@holdenk, seems like the test failure wasn't caused by this PR. Dose your -1
at
12 matches
Mail list logo
