[GitHub] [spark] HyukjinKwon commented on pull request #30143: [SPARK-32084][PYTHON][SQL] Expand dictionary functions

2020-10-26 Thread GitBox
HyukjinKwon commented on pull request #30143: URL: https://github.com/apache/spark/pull/30143#issuecomment-716930118 Merged to master. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HyukjinKwon commented on pull request #30143: [SPARK-32084][PYTHON][SQL] Expand dictionary functions

2020-10-25 Thread GitBox
HyukjinKwon commented on pull request #30143: URL: https://github.com/apache/spark/pull/30143#issuecomment-716246037 The current changes look pretty good to go. Let me know when you think it's ready. I'll take one more look and merge it in.

[GitHub] [spark] HyukjinKwon commented on pull request #30143: [SPARK-32084][PYTHON][SQL] Expand dictionary functions

2020-10-25 Thread GitBox
HyukjinKwon commented on pull request #30143: URL: https://github.com/apache/spark/pull/30143#issuecomment-716245920 Yeah, I think we can just keep docstrings as-is. For grouping stuff, I think it's okay to don't change since it's mainly for code readers. There were similar changes

[GitHub] [spark] HyukjinKwon commented on pull request #30143: [SPARK-32084][PYTHON][SQL] Expand dictionary functions

2020-10-23 Thread GitBox
HyukjinKwon commented on pull request #30143: URL: https://github.com/apache/spark/pull/30143#issuecomment-715647432 > Add proper NumPy-style docstrings to expanded functions. Oh, let's don't do this in this PR. It should add some dependencies into GitHub Actions, fix the script

[GitHub] [spark] HyukjinKwon commented on pull request #30143: [SPARK-32084][PYTHON][SQL] Expand dictionary functions

2020-10-23 Thread GitBox
HyukjinKwon commented on pull request #30143: URL: https://github.com/apache/spark/pull/30143#issuecomment-715647106 Nice, @zero323. Thanks for working on this. This is an automated message from the Apache Git Service. To