[GitHub] [spark] HyukjinKwon commented on pull request #30382: [SPARK-33457][PYTHON] Adjust mypy configuration

2020-11-24 Thread GitBox
HyukjinKwon commented on pull request #30382: URL: https://github.com/apache/spark/pull/30382#issuecomment-733358041 Merged to master. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [spark] HyukjinKwon commented on pull request #30382: [SPARK-33457][PYTHON] Adjust mypy configuration

2020-11-23 Thread GitBox
HyukjinKwon commented on pull request #30382: URL: https://github.com/apache/spark/pull/30382#issuecomment-732518086 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] HyukjinKwon commented on pull request #30382: [SPARK-33457][PYTHON] Adjust mypy configuration

2020-11-22 Thread GitBox
HyukjinKwon commented on pull request #30382: URL: https://github.com/apache/spark/pull/30382#issuecomment-731876987 @zero323, let me know when you think this is ready. Looks fine to me. This is an automated message from the

[GitHub] [spark] HyukjinKwon commented on pull request #30382: [SPARK-33457][PYTHON] Adjust mypy configuration

2020-11-15 Thread GitBox
HyukjinKwon commented on pull request #30382: URL: https://github.com/apache/spark/pull/30382#issuecomment-727693447 My only concern is the maintenance cost for being strict. If it doesn't add non-trivial overhead, I am good to be more strict on the type hints. ---