[GitHub] [spark] HyukjinKwon commented on pull request #32745: [SPARK-35523] Fix the default value in Data Source Options page

2021-06-04 Thread GitBox
HyukjinKwon commented on pull request #32745: URL: https://github.com/apache/spark/pull/32745#issuecomment-853577413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For que

[GitHub] [spark] HyukjinKwon commented on pull request #32745: [SPARK-35523] Fix the default value in Data Source Options page

2021-06-03 Thread GitBox
HyukjinKwon commented on pull request #32745: URL: https://github.com/apache/spark/pull/32745#issuecomment-854362010 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [spark] HyukjinKwon commented on pull request #32745: [SPARK-35523] Fix the default value in Data Source Options page

2021-06-03 Thread GitBox
HyukjinKwon commented on pull request #32745: URL: https://github.com/apache/spark/pull/32745#issuecomment-854344987 can you also fix `ignoreNullFields` in JSON? it defaults to `spark.sql.jsonGenerator.ignoreNullFields`. -- This is an automated message from the Apache Git Service. To res

[GitHub] [spark] HyukjinKwon commented on pull request #32745: [SPARK-35523] Fix the default value in Data Source Options page

2021-06-03 Thread GitBox
HyukjinKwon commented on pull request #32745: URL: https://github.com/apache/spark/pull/32745#issuecomment-854276008 @itholic can you resolve conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on pull request #32745: [SPARK-35523] Fix the default value in Data Source Options page

2021-06-02 Thread GitBox
HyukjinKwon commented on pull request #32745: URL: https://github.com/apache/spark/pull/32745#issuecomment-853577413 can we add default values at https://github.com/apache/spark/blob/5ff5770e5c4aeeec9c5f0ab173c49dfe003e5eba/docs/sql-data-sources-jdbc.md too? -- This is an automated mess