[GitHub] [spark] HyukjinKwon commented on pull request #33329: [WIP][SPARK-35917][SHUFFLE][CORE][3.2] Disable push-based shuffle feature to prevent it from being used

2021-07-14 Thread GitBox
HyukjinKwon commented on pull request #33329: URL: https://github.com/apache/spark/pull/33329#issuecomment-879717729 Being conservative sounds fine to me too since we're in core. I will leave it to you @mridulm. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] HyukjinKwon commented on pull request #33329: [WIP][SPARK-35917][SHUFFLE][CORE][3.2] Disable push-based shuffle feature to prevent it from being used

2021-07-14 Thread GitBox
HyukjinKwon commented on pull request #33329: URL: https://github.com/apache/spark/pull/33329#issuecomment-879717569 I am fine either way. I was just thinking that it's fine to have some incompatibility or breaking stuff as long as we document so and it's disabled by default (since this

[GitHub] [spark] HyukjinKwon commented on pull request #33329: [WIP][SPARK-35917][SHUFFLE][CORE][3.2] Disable push-based shuffle feature to prevent it from being used

2021-07-13 Thread GitBox
HyukjinKwon commented on pull request #33329: URL: https://github.com/apache/spark/pull/33329#issuecomment-879569468 Yeah, I think we won't necessarily have to make it failed when it's enabled. I believe it's fine to explicitly document that this feature is unstable, and either