HyukjinKwon commented on pull request #34314:
URL: https://github.com/apache/spark/pull/34314#issuecomment-976093250
yeah, that is fine because it already doesn't work with 1.2 and 1.1 and no
regression.
--
This is an automated message from the Apache Git Service.
To respond to the messa
HyukjinKwon commented on pull request #34314:
URL: https://github.com/apache/spark/pull/34314#issuecomment-976037376
@Yikun, if you're stuck to support this with old pandas versions, we can
just conditionally run the tests with only pandas 1.3+ for now
--
This is an automated message fro
HyukjinKwon commented on pull request #34314:
URL: https://github.com/apache/spark/pull/34314#issuecomment-975165011
Testing on 1.1.x or 1.2.x should be good enough for the fix itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on pull request #34314:
URL: https://github.com/apache/spark/pull/34314#issuecomment-975164734
It's actually documented here;
https://github.com/apache/spark/blob/master/python/setup.py#L115.
We should probably have to bump up .. ideally we should test all the
comb
HyukjinKwon commented on pull request #34314:
URL: https://github.com/apache/spark/pull/34314#issuecomment-975016963
@Yikun, I am very sorry but I realised that this patch breaks the test cases
with lower pandas versions (because it requires to have
https://pandas.pydata.org/pandas-docs/st
HyukjinKwon commented on pull request #34314:
URL: https://github.com/apache/spark/pull/34314#issuecomment-971092144
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
HyukjinKwon commented on pull request #34314:
URL: https://github.com/apache/spark/pull/34314#issuecomment-946331195
cc @xinrong-databricks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
