[GitHub] [spark] Karl-WangSK commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-13 Thread GitBox
Karl-WangSK commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-673496112 please review the benchmark This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] Karl-WangSK commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-13 Thread GitBox
Karl-WangSK commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-673495331 @viirya @maropu This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] Karl-WangSK commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-13 Thread GitBox
Karl-WangSK commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-673426929 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] Karl-WangSK commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-13 Thread GitBox
Karl-WangSK commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-673382458 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] Karl-WangSK commented on pull request #29360: [SPARK-32542][SQL]Add a Batch in Optimizer to improve performance in multidimensional analysis

2020-08-09 Thread GitBox
Karl-WangSK commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-671141480 > Can you add some tests for this? And, as @maropu said, please also run some benchmarks to show the performance improvement. Thanks. ok