Kimahriman edited a comment on pull request #32448: URL: https://github.com/apache/spark/pull/32448#issuecomment-860328810
So @viirya's comment made me realize that `StructType.merge` isn't quite the right solution since it immediately fails on exact type mismatch and can't handle similar types like float/double. I updated things locally to not use it anymore and just resolve things based on name and let the types figure themselves out later like other unions. Separately, the `StructType.merge` not considering case sensitivity is still a bug that can crop up with unions (not even just unionByName with null filling). So I can either just push the minor update I have here to address the comment, or I can close this and open two separate PRs to address each individually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
