[GitHub] [spark] LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-03-21 Thread GitBox
LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-602143421 Ah, you meant the `beeline>`. Sorry, I tested via thriftserver, I will change to spark > Also, @La

[GitHub] [spark] LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-03-21 Thread GitBox
LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-602142773 > Also, @LantaoJin . Please fix the PR description. For example, the following doesn't work. > > `

[GitHub] [spark] LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-03-21 Thread GitBox
LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-602007076 retest this please This is an automated

[GitHub] [spark] LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-03-13 Thread GitBox
LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-598667465 retest please This is an automated messa

[GitHub] [spark] LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-02-03 Thread GitBox
LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-581423446 > The entry point of `Catalog` is `SparkSession#catalog`. It doesn't help if we only move `Catalog` to ca

[GitHub] [spark] LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-02-03 Thread GitBox
LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-581401772 I think `def uncacheTable(tableName: String): Unit` in Catalog.scala is already the general function to u

[GitHub] [spark] LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-02-03 Thread GitBox
LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-581294858 > To do that, `SessionCatalog` needs a reference of `SparkSession`. We need pass `SparkSession` to the co

[GitHub] [spark] LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-02-03 Thread GitBox
LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-581290732 To do that, `SessionCatalog` needs a reference of `SparkSession`. We need pass it to the construct argume

[GitHub] [spark] LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-02-01 Thread GitBox
LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-581030414 > I think it makes sense, but we should follow how similar things are done in DROP TABLE. I think

[GitHub] [spark] LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view

2020-01-30 Thread GitBox
LantaoJin commented on issue #27185: [SPARK-30494][SQL] Avoid duplicated cached RDD when replace an existing view URL: https://github.com/apache/spark/pull/27185#issuecomment-580579184 Gentle ping @cloud-fan @HyukjinKwon @maropu @dongjoon-hyun @kiszk @srowen ---