[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-23 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-663327849 Hi @cloud-fan @JkSelf , please help to review this PR. I am going to file a new PR for handling three tables SMJ skew which scope is beyond this PR.

[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-22 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-662287457 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-16 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-659805674 Gentle ping @cloud-fan This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-16 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-659245767 Now I add another test case which is very similar with the user case in the description. I think it's done. Could you have a chance to review it? @cloud-fan

[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654698752 To simply the UT. I introduced this pattern. And I have recognized there is problem for agg. I will refactor code and description. Emm. Make it WIP.

[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654697631 Yes. You are correct. I have recognized this case. I will should skip aggregation :( This is an automated

[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654661214 Also this PR can work with #28947 to match more pattern together. This is an automated message from the