[GitHub] [spark] LorenzoMartini commented on pull request #36457: [SPARK-39107][SQL] Account for empty string input in regex replace

2022-05-06 Thread GitBox
LorenzoMartini commented on PR #36457: URL: https://github.com/apache/spark/pull/36457#issuecomment-1119707274 Thanks @srowen! Sounds good to me, the constraint would just be a nit and I'm happy to keep it as is to avoid additional complications / excessive fixing. Can we merge this :)? -

[GitHub] [spark] LorenzoMartini commented on pull request #36457: [SPARK-39107][SQL] Account for empty string input in regex replace

2022-05-09 Thread GitBox
LorenzoMartini commented on PR #36457: URL: https://github.com/apache/spark/pull/36457#issuecomment-1121260349 Github UI shows failing but nothing is actually failing here. All comments should be addressed, can we get a merge on this please? -- This is an automated message from the Apache