LuciferYang commented on code in PR #38366:
URL: https://github.com/apache/spark/pull/38366#discussion_r1002854458
##########
.github/workflows/benchmark.yml:
##########
@@ -105,9 +105,11 @@ jobs:
run: cd tpcds-kit/tools && make OS=LINUX
- name: Install Java ${{ github.event.inputs.jdk }}
if: steps.cache-tpcds-sf-1.outputs.cache-hit != 'true'
- uses: actions/setup-java@v1
+ uses: actions/setup-java@v3
with:
+ distribution: 'zulu'
java-version: ${{ github.event.inputs.jdk }}
+ check-latest: true
Review Comment:
> Is there any specifc reason to use check-latest?
>
> This might cause use latest java without cache, then build might slower
(more time to download latest java).
>
> https://github.com/actions/setup-java#check-latest
Ok, I will close this one, for `check-latest: true` because I have not
finished reading the document, so it is temporarily set to true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
