subject:"\[GitHub\] \[spark\] LuciferYang commented on a diff in pull request #40291\: \[WIP\]\[SPARK\-42578\]\[CONNECT\] Add JDBC to DataFrameWriter"

[GitHub] [spark] LuciferYang commented on a diff in pull request #40291: [WIP][SPARK-42578][CONNECT] Add JDBC to DataFrameWriter

2023-03-08 Thread via GitHub

LuciferYang commented on code in PR #40291: URL: https://github.com/apache/spark/pull/40291#discussion_r1129191369 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala: ## @@ -345,6 +345,44 @@ final class DataFrameWriter[T] private[sql] (ds:

[GitHub] [spark] LuciferYang commented on a diff in pull request #40291: [WIP][SPARK-42578][CONNECT] Add JDBC to DataFrameWriter

2023-03-05 Thread via GitHub

LuciferYang commented on code in PR #40291: URL: https://github.com/apache/spark/pull/40291#discussion_r1125957292 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala: ## @@ -345,6 +345,37 @@ final class DataFrameWriter[T] private[sql] (ds: