LuciferYang commented on code in PR #41505:
URL: https://github.com/apache/spark/pull/41505#discussion_r1222624212


##########
sql/core/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -5292,6 +5292,183 @@ object functions {
    */
   def hours(e: Column): Column = withExpr { Hours(e.expr) }
 
+  /**
+   * Creates a map after splitting the text into key/value pairs using 
delimiters.
+   * Both `pairDelim` and `keyValueDelim` are treated as regular expressions.
+   *
+   * @group map_funcs
+   * @since 3.5.0
+   */
+  def str_to_map(text: Column, pairDelim: Column, keyValueDelim: Column): 
Column = withExpr {

Review Comment:
   hmm... does these new functions have test coverage?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to