[GitHub] [spark] LuciferYang commented on pull request #31776: [SPARK-34661][SQL] Clean up `OriginalType` and `DecimalMetadata ` usage in Parquet related code

2021-05-17 Thread GitBox
LuciferYang commented on pull request #31776: URL: https://github.com/apache/spark/pull/31776#issuecomment-841931849 thx ~ @srowen @HyukjinKwon @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] LuciferYang commented on pull request #31776: [SPARK-34661][SQL] Clean up `OriginalType` and `DecimalMetadata ` usage in Parquet related code

2021-05-16 Thread GitBox
LuciferYang commented on pull request #31776: URL: https://github.com/apache/spark/pull/31776#issuecomment-841931849 thx ~ @srowen @HyukjinKwon @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] LuciferYang commented on pull request #31776: [SPARK-34661][SQL] Clean up `OriginalType` and `DecimalMetadata ` usage in Parquet related code

2021-04-01 Thread GitBox
LuciferYang commented on pull request #31776: URL: https://github.com/apache/spark/pull/31776#issuecomment-812272546 Gentle ping, @wangyum @HyukjinKwon @dongjoon-hyun @maropu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] LuciferYang commented on pull request #31776: [SPARK-34661][SQL] Clean up `OriginalType` and `DecimalMetadata ` usage in Parquet related code

2021-03-31 Thread GitBox
LuciferYang commented on pull request #31776: URL: https://github.com/apache/spark/pull/31776#issuecomment-811642573 Thanks ~ @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] LuciferYang commented on pull request #31776: [SPARK-34661][SQL] Clean up `OriginalType` and `DecimalMetadata ` usage in Parquet related code

2021-03-30 Thread GitBox
LuciferYang commented on pull request #31776: URL: https://github.com/apache/spark/pull/31776#issuecomment-810124913 > I think this is related to #31685 too @sunchao Do you know why is this PR no longer updated? thx ~ -- This is an automated message from the Apache Git

[GitHub] [spark] LuciferYang commented on pull request #31776: [SPARK-34661][SQL] Clean up `OriginalType` and `DecimalMetadata ` usage in Parquet related code

2021-03-18 Thread GitBox
LuciferYang commented on pull request #31776: URL: https://github.com/apache/spark/pull/31776#issuecomment-802570617 > I don't really know enough to evaluate this. It looks reasonable and tests pass. Are there any compatibility concerns, or possible changes to behavior you can think of?

[GitHub] [spark] LuciferYang commented on pull request #31776: [SPARK-34661][SQL] Clean up `OriginalType` and `DecimalMetadata ` usage in Parquet related code

2021-03-16 Thread GitBox
LuciferYang commented on pull request #31776: URL: https://github.com/apache/spark/pull/31776#issuecomment-800757254 cc @dongjoon-hyun @HyukjinKwon @srowen @maropu can you help to review this pr? thx ~ This is an automated