[GitHub] [spark] LuciferYang commented on pull request #36467: [DON'T MERGE] Replace `finalize()` with custom ReferenceQueue for `RocksDBIterator` cleanup

LuciferYang commented on PR #36467: URL: https://github.com/apache/spark/pull/36467#issuecomment-1120149831 If `DEBUG_LEVEL=1` https://github.com/facebook/rocksdb/blob/b7119ff818f83b54a46602ac1f23d4fe2add1bfc/db/column_family.cc#L1488-L1495 ```c ColumnFamilySet::~ColumnFamil

[GitHub] [spark] LuciferYang commented on pull request #36467: [DON'T MERGE] Replace `finalize()` with custom ReferenceQueue for `RocksDBIterator` cleanup

LuciferYang commented on PR #36467: URL: https://github.com/apache/spark/pull/36467#issuecomment-1120148690 Description of `DEBUG_LEVEL` as follows: https://github.com/facebook/rocksdb/blob/7b55b508390d792ff31a416b63d474a2a6780588/Makefile#L31-L42 ``` # DEBUG_LEVEL can have

[GitHub] [spark] LuciferYang commented on pull request #36467: [DON'T MERGE] Replace `finalize()` with custom ReferenceQueue for `RocksDBIterator` cleanup

LuciferYang commented on PR #36467: URL: https://github.com/apache/spark/pull/36467#issuecomment-1120132321 The issue will not cause vm crash when using the official release `rocksdbjni`, so if it's not worth fixing, I can close this pr . -- This is an automated message from the Apache Gi

[GitHub] [spark] LuciferYang commented on pull request #36467: [DON'T MERGE] Replace `finalize()` with custom ReferenceQueue for `RocksDBIterator` cleanup

LuciferYang commented on PR #36467: URL: https://github.com/apache/spark/pull/36467#issuecomment-1120131542 @dongjoon-hyun After SPARK-38896, I think all `LevelDB/RocksDBIterator` has been explicitly closed in Spark code, so I want to clean up the code related to `finalize()` in `Le

[GitHub] [spark] LuciferYang commented on pull request #36467: [DON'T MERGE] Replace `finalize()` with custom ReferenceQueue for `RocksDBIterator` cleanup

LuciferYang commented on PR #36467: URL: https://github.com/apache/spark/pull/36467#issuecomment-1120124977 https://github.com/apache/spark/pull/36403#issuecomment-1114466277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] LuciferYang commented on pull request #36467: [DON'T MERGE] Replace `finalize()` with custom ReferenceQueue for `RocksDBIterator` cleanup

LuciferYang commented on PR #36467: URL: https://github.com/apache/spark/pull/36467#issuecomment-1119368808 Just for test now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.