[GitHub] [spark] LuciferYang edited a comment on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-18 Thread GitBox
LuciferYang edited a comment on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-842979946 @maropu for the above problem, can we add a case similar to the following to compare the result of `reflection api and using ClassBodyEvaluator.getBytecodes api`

[GitHub] [spark] LuciferYang edited a comment on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-18 Thread GitBox
LuciferYang edited a comment on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-842979946 @maropu for the above problem, can we add a case similar to the following to compare the result of `reflection api and using ClassBodyEvaluator.getBytecodes api`

[GitHub] [spark] LuciferYang edited a comment on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-18 Thread GitBox
LuciferYang edited a comment on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-842979946 @maropu for the above problem, can we add a case similar to the following to compare the result of `reflection api and using ClassBodyEvaluator.getBytecodes api`

[GitHub] [spark] LuciferYang edited a comment on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-18 Thread GitBox
LuciferYang edited a comment on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-842973792 ![image](https://user-images.githubusercontent.com/1475305/118617609-5ec87c80-b7f5-11eb-94ae-f9f8a40b3f96.png) @maropu `Reservoir` in

[GitHub] [spark] LuciferYang edited a comment on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-18 Thread GitBox
LuciferYang edited a comment on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-842973792 ![image](https://user-images.githubusercontent.com/1475305/118617609-5ec87c80-b7f5-11eb-94ae-f9f8a40b3f96.png) @maropu `Reservoir` in

[GitHub] [spark] LuciferYang edited a comment on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-18 Thread GitBox
LuciferYang edited a comment on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-842973792 ![image](https://user-images.githubusercontent.com/1475305/118617609-5ec87c80-b7f5-11eb-94ae-f9f8a40b3f96.png) @maropu `Reservoir` in

[GitHub] [spark] LuciferYang edited a comment on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-17 Thread GitBox
LuciferYang edited a comment on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-842148206 New test case will fail when running with other tests, let me check this. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] LuciferYang edited a comment on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

2021-05-17 Thread GitBox
LuciferYang edited a comment on pull request #32536: URL: https://github.com/apache/spark/pull/32536#issuecomment-842148206 New test case will fail when running with other tests, let me check this. -- This is an automated message from the Apache Git Service. To respond to the message,