[GitHub] [spark] MaxGekk commented on a diff in pull request #37483: [SPARK-40112][SQL] Improve the TO_BINARY() function

2022-08-24 Thread GitBox
MaxGekk commented on code in PR #37483: URL: https://github.com/apache/spark/pull/37483#discussion_r953733474 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -452,6 +452,90 @@ class StringExpressionsSuite extends

[GitHub] [spark] MaxGekk commented on a diff in pull request #37483: [SPARK-40112][SQL] Improve the TO_BINARY() function

2022-08-24 Thread GitBox
MaxGekk commented on code in PR #37483: URL: https://github.com/apache/spark/pull/37483#discussion_r953732921 ## core/src/main/resources/error/error-classes.json: ## @@ -70,6 +70,11 @@ "Another instance of this query was just started by a concurrent session." ]

[GitHub] [spark] MaxGekk commented on a diff in pull request #37483: [SPARK-40112][SQL] Improve the TO_BINARY() function

2022-08-23 Thread GitBox
MaxGekk commented on code in PR #37483: URL: https://github.com/apache/spark/pull/37483#discussion_r952361982 ## core/src/main/resources/error/error-classes.json: ## @@ -70,6 +70,11 @@ "Another instance of this query was just started by a concurrent session." ]

[GitHub] [spark] MaxGekk commented on a diff in pull request #37483: [SPARK-40112][SQL] Improve the TO_BINARY() function

2022-08-22 Thread GitBox
MaxGekk commented on code in PR #37483: URL: https://github.com/apache/spark/pull/37483#discussion_r951072891 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala: ## @@ -169,6 +169,39 @@ private[sql] object QueryExecutionErrors extends

[GitHub] [spark] MaxGekk commented on a diff in pull request #37483: [SPARK-40112][SQL] Improve the TO_BINARY() function

2022-08-20 Thread GitBox
MaxGekk commented on code in PR #37483: URL: https://github.com/apache/spark/pull/37483#discussion_r950732296 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala: ## @@ -452,6 +452,90 @@ class StringExpressionsSuite extends