[GitHub] [spark] MaxGekk commented on a diff in pull request #40609: [SPARK-42316][SQL] Assign name to _LEGACY_ERROR_TEMP_2044

2023-04-04 Thread via GitHub
MaxGekk commented on code in PR #40609: URL: https://github.com/apache/spark/pull/40609#discussion_r1157127026 ## core/src/main/resources/error/error-classes.json: ## @@ -35,6 +35,12 @@ ], "sqlState" : "22003" }, + "BINARY_ARITHMETIC_CAUSE_OVERFLOW" : { Review Com

[GitHub] [spark] MaxGekk commented on a diff in pull request #40609: [SPARK-42316][SQL] Assign name to _LEGACY_ERROR_TEMP_2044

2023-03-30 Thread via GitHub
MaxGekk commented on code in PR #40609: URL: https://github.com/apache/spark/pull/40609#discussion_r1153638873 ## sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala: ## @@ -625,6 +625,20 @@ class QueryExecutionErrorsSuite } } + test("B

[GitHub] [spark] MaxGekk commented on a diff in pull request #40609: [SPARK-42316][SQL] Assign name to _LEGACY_ERROR_TEMP_2044

2023-03-30 Thread via GitHub
MaxGekk commented on code in PR #40609: URL: https://github.com/apache/spark/pull/40609#discussion_r1153634383 ## sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala: ## @@ -625,6 +625,20 @@ class QueryExecutionErrorsSuite } } + test("B