MaxGekk commented on issue #25716: [SPARK-29012][SQL] Support special timestamp
values
URL: https://github.com/apache/spark/pull/25716#issuecomment-533899173
This PR https://github.com/apache/spark/pull/25834 hide the feature under
the SQL config `spark.sql.dialect = "PostgreSQL"`
MaxGekk commented on issue #25716: [SPARK-29012][SQL] Support special timestamp
values
URL: https://github.com/apache/spark/pull/25716#issuecomment-532514518
> so do you plan to hide this change behind the configuration
spark.sql.dialect later?
@HyukjinKwon Yes, I do. I would do
MaxGekk commented on issue #25716: [SPARK-29012][SQL] Support special timestamp
values
URL: https://github.com/apache/spark/pull/25716#issuecomment-532116882
@dongjoon-hyun @maropu Can you merge this PR? Checking the flag could be
added in #25697 itself or in a separate follow-up PR after
MaxGekk commented on issue #25716: [SPARK-29012][SQL] Support special timestamp
values
URL: https://github.com/apache/spark/pull/25716#issuecomment-530826650
I have some performance related concerns regarding to using the config. In
current implementation, decision is pretty cheap - just
MaxGekk commented on issue #25716: [SPARK-29012][SQL] Support special timestamp
values
URL: https://github.com/apache/spark/pull/25716#issuecomment-530697767
@maropu @dongjoon-hyun Can we continue with the PR or we are waiting for
@gengliangwang 's
MaxGekk commented on issue #25716: [SPARK-29012][SQL] Support special timestamp
values
URL: https://github.com/apache/spark/pull/25716#issuecomment-529559911
@dongjoon-hyun @cloud-fan @maropu Could you take a look at this when you
have time.
