Ngone51 commented on a change in pull request #28028: [SPARK-31259][CORE] Fix
log error of curRequestSize in ShuffleBlockFetcherIterator
URL: https://github.com/apache/spark/pull/28028#discussion_r398307088
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -329,27 +329,25 @@ final class ShuffleBlockFetcherIterator(
private def createFetchRequest(
blocks: Seq[FetchBlockInfo],
- address: BlockManagerId,
- curRequestSize: Long): FetchRequest = {
- logDebug(s"Creating fetch request of $curRequestSize at $address "
+ address: BlockManagerId): FetchRequest = {
+ logDebug(s"Creating fetch request of ${blocks.map(_.size).sum} at $address
"
Review comment:
In non batch mode, it is. But in batch mode, `blocks` here can a part of
all blocks as they will be grouped by `maxBlocksInFlightPerAddress` before
calling `createFetchRequest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
