[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489187225 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Lead

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489186319 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Lead

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r488343168 ## File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala ## @@ -79,12 +79,23 @@ private[spark] class CoarseGrainedE

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487937373 ## File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala ## @@ -79,12 +79,23 @@ private[spark] class CoarseGrainedE

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487928796 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -891,16 +896,13 @@ private[deploy] class Master( logInfo(s"Decomm

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487867415 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ## @@ -467,67 +467,42 @@ class CoarseGrainedSche

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487832013 ## File path: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala ## @@ -70,7 +70,7 @@ private[deploy] class Worker( if (conf.get(config.DE

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487675868 ## File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ## @@ -581,7 +581,10 @@ private[spark] class ExecutorAllocationManager(

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487673792 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -891,16 +891,13 @@ private[deploy] class Master( logInfo(s"Decomm

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487672016 ## File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala ## @@ -264,17 +253,21 @@ private[spark] class CoarseGraine

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487669091 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ## @@ -467,67 +469,44 @@ class CoarseGrainedSche

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487668029 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ## @@ -467,67 +469,44 @@ class CoarseGrainedSche

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487664347 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ## @@ -467,67 +469,44 @@ class CoarseGrainedSche

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487660636 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ## @@ -467,67 +469,44 @@ class CoarseGrainedSche

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487659285 ## File path: core/src/test/scala/org/apache/spark/scheduler/WorkerDecommissionSuite.scala ## @@ -31,7 +31,7 @@ import org.apache.spark.util.{RpcUtils, S

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487658824 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1809,7 +1811,7 @@ private[spark] class BlockManager( blocksToRem

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487657421 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedClusterMessage.scala ## @@ -95,8 +95,13 @@ private[spark] object Coarse

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487633782 ## File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala ## @@ -166,17 +166,6 @@ private[spark] class CoarseGrained

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487628196 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,14 +245,14 @@ private[deploy] class Master( logError("Lead

[GitHub] [spark] Ngone51 commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

Ngone51 commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487626850 ## File path: core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ## @@ -94,8 +94,9 @@ private[spark] trait ExecutorAllocationClient {