[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-11-09 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r745246686 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -871,7 +871,13 @@ private[spark] class TaskSchedulerImpl(

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-11-08 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r745246242 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -870,7 +870,13 @@ private[spark] class TaskSchedulerImpl(

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-28 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r717193397 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -18,23 +18,24 @@ package org.apache.spark.scheduler i

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-28 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r717527179 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -870,7 +870,13 @@ private[spark] class TaskSchedulerImpl(

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-28 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r717525656 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -870,7 +870,13 @@ private[spark] class TaskSchedulerImpl(

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-28 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r717524337 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -34,7 +36,8 @@ import org.apache.spark.internal.config i

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-28 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r717523885 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -1995,6 +1998,88 @@ class TaskSchedulerImplSuite extends

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-28 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r717522484 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -1995,6 +1998,88 @@ class TaskSchedulerImplSuite extends

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-27 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r717193397 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -18,23 +18,24 @@ package org.apache.spark.scheduler i

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-07 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r704059869 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -1995,6 +2000,61 @@ class TaskSchedulerImplSuite extends

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-07 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r703279670 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -1995,6 +2000,61 @@ class TaskSchedulerImplSuite extends

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-06 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r703178285 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -1995,6 +2000,61 @@ class TaskSchedulerImplSuite extends

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-06 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r703140913 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -1995,6 +2000,61 @@ class TaskSchedulerImplSuite extends

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-02 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r701033071 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -1995,6 +2000,61 @@ class TaskSchedulerImplSuite extends

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-01 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r700126164 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -1995,6 +2000,61 @@ class TaskSchedulerImplSuite extends

[GitHub] [spark] Ngone51 commented on a change in pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

2021-09-01 Thread GitBox
Ngone51 commented on a change in pull request #33872: URL: https://github.com/apache/spark/pull/33872#discussion_r700126164 ## File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ## @@ -1995,6 +2000,61 @@ class TaskSchedulerImplSuite extends