[GitHub] [spark] Ngone51 commented on pull request #31942: [SPARK-34834][NETWORK] Fix a potential Netty memory leak in TransportResponseHandler.

2021-03-30 Thread GitBox
Ngone51 commented on pull request #31942: URL: https://github.com/apache/spark/pull/31942#issuecomment-810312456 > ok so for the shuffle block iterator it gets released in here in the normal case: https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/storage/S

[GitHub] [spark] Ngone51 commented on pull request #31942: [SPARK-34834][NETWORK] Fix a potential Netty memory leak in TransportResponseHandler.

2021-03-28 Thread GitBox
Ngone51 commented on pull request #31942: URL: https://github.com/apache/spark/pull/31942#issuecomment-809035511 I'm also confused with this part. I don't even see a place where the `resp.body()` (a.k.a `ManagedBuffer`) is referenced before the `TransportResponseHandler` handle the `Respon