[GitHub] [spark] WamBamBoozle edited a comment on pull request #31162: [SPARK-34033][R] SparkR Daemon Initialization

2021-02-25 Thread GitBox
WamBamBoozle edited a comment on pull request #31162: URL: https://github.com/apache/spark/pull/31162#issuecomment-772732386 @srowen, you write > I dont' know much about R - why does this help improve performance? It is like moving the invariant expression out of a loop. It is

[GitHub] [spark] WamBamBoozle edited a comment on pull request #31162: [SPARK-34033][R] SparkR Daemon Initialization

2021-02-05 Thread GitBox
WamBamBoozle edited a comment on pull request #31162: URL: https://github.com/apache/spark/pull/31162#issuecomment-772732386 @srowen, you write > I dont' know much about R - why does this help improve performance? It is like moving the invariant expression out of the loop. It i

[GitHub] [spark] WamBamBoozle edited a comment on pull request #31162: [SPARK-34033][R] SparkR Daemon Initialization

2021-02-04 Thread GitBox
WamBamBoozle edited a comment on pull request #31162: URL: https://github.com/apache/spark/pull/31162#issuecomment-772732386 @srowen, you write > I dont' know much about R - why does this help improve performance? It is like moving the invariant expression out of the loop. It i

[GitHub] [spark] WamBamBoozle edited a comment on pull request #31162: [SPARK-34033][R] SparkR Daemon Initialization

2021-02-03 Thread GitBox
WamBamBoozle edited a comment on pull request #31162: URL: https://github.com/apache/spark/pull/31162#issuecomment-772732386 @srowen, you write > I dont' know much about R - why does this help improve performance? It is like moving the invariant expression out of the loop. It i

[GitHub] [spark] WamBamBoozle edited a comment on pull request #31162: [SPARK-34033][R] SparkR Daemon Initialization

2021-01-13 Thread GitBox
WamBamBoozle edited a comment on pull request #31162: URL: https://github.com/apache/spark/pull/31162#issuecomment-759780566 Greetings @HyukjinKwon Thanks so much for your review of #31072! I had to close that PR as I forgot rebasing git causes bad things to happen in github.