[GitHub] [spark] WweiL commented on a diff in pull request #40586: [SPARK-42939][SS][CONNECT] Core streaming Python API for Spark Connect

2023-04-04 Thread via GitHub
WweiL commented on code in PR #40586: URL: https://github.com/apache/spark/pull/40586#discussion_r1157836737 ## python/pyspark/sql/connect/streaming/readwriter.py: ## @@ -0,0 +1,484 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [spark] WweiL commented on a diff in pull request #40586: [SPARK-42939][SS][CONNECT] Core streaming Python API for Spark Connect

2023-03-30 Thread via GitHub
WweiL commented on code in PR #40586: URL: https://github.com/apache/spark/pull/40586#discussion_r1153899173 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -2120,7 +2130,6 @@ class SparkConnectPlanner(val

[GitHub] [spark] WweiL commented on a diff in pull request #40586: [SPARK-42939][SS][CONNECT] Core streaming Python API for Spark Connect

2023-03-29 Thread via GitHub
WweiL commented on code in PR #40586: URL: https://github.com/apache/spark/pull/40586#discussion_r1152323338 ## python/pyspark/sql/connect/streaming/query.py: ## @@ -0,0 +1,173 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [spark] WweiL commented on a diff in pull request #40586: [SPARK-42939][SS][CONNECT] Core streaming Python API for Spark Connect

2023-03-29 Thread via GitHub
WweiL commented on code in PR #40586: URL: https://github.com/apache/spark/pull/40586#discussion_r1152307065 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -1969,6 +2014,136 @@ class SparkConnectPlanner(val

[GitHub] [spark] WweiL commented on a diff in pull request #40586: [SPARK-42939][SS][CONNECT] Core streaming Python API for Spark Connect

2023-03-29 Thread via GitHub
WweiL commented on code in PR #40586: URL: https://github.com/apache/spark/pull/40586#discussion_r1152296460 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -1969,6 +2014,136 @@ class SparkConnectPlanner(val