[GitHub] [spark] Yikun commented on a change in pull request #32821: [SPARK-35342][PYTHON] Introduce DecimalOps and make `isnull` method data-type-based

2021-06-18 Thread GitBox
Yikun commented on a change in pull request #32821: URL: https://github.com/apache/spark/pull/32821#discussion_r654208604 ## File path: python/pyspark/pandas/data_type_ops/base.py ## @@ -300,6 +303,13 @@ def prepare(self, col: pd.Series) -> pd.Series: """Prepare column

[GitHub] [spark] Yikun commented on a change in pull request #32821: [SPARK-35342][PYTHON] Introduce DecimalOps and make `isnull` method data-type-based

2021-06-15 Thread GitBox
Yikun commented on a change in pull request #32821: URL: https://github.com/apache/spark/pull/32821#discussion_r652277828 ## File path: python/pyspark/pandas/data_type_ops/num_ops.py ## @@ -395,3 +400,17 @@ def astype( return _as_string_type(index_ops, dtype, null_

[GitHub] [spark] Yikun commented on a change in pull request #32821: [SPARK-35342][PYTHON] Introduce DecimalOps

2021-06-14 Thread GitBox
Yikun commented on a change in pull request #32821: URL: https://github.com/apache/spark/pull/32821#discussion_r649663634 ## File path: python/pyspark/pandas/tests/data_type_ops/test_decimal_ops.py ## @@ -0,0 +1,65 @@ +# +# Licensed to the Apache Software Foundation (ASF) under