[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-997161716 @dongjoon-hyun Much thanks for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-996415418 @dongjoon-hyun Thanks for your review, addressed your comments in latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-995707677 Retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-995571901 > This PR doesn't have a test case. Could you add a test coverage for your code path please? Sure, thanks for reminder, I have added the testcase in latest commit. >

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-990744490 @dongjoon-hyun Thanks for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-983685340 > In theory, this feature looks unsafe because there is a chance to leak the pre-populated resources because they have no owner yet. Yes, that's a good point, and the

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-973790941 @dongjoon-hyun Would you mind giving some suggestion on this? Sorry to ping wrong person in https://github.com/apache/spark/pull/34599#issuecomment-968704348 . : ) -- This is

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-972435876 @holdenk Thanks for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-971305980 Intergration test failed is unrelated, ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-968704348 cc @Dooyoung-Hwang @holdenk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the