[GitHub] [spark] Yikun commented on pull request #36353: [SPARK-38946][PYTHON][PS] Generates a new dataframe instead of operating inplace in setitem

Yikun commented on PR #36353: URL: https://github.com/apache/spark/pull/36353#issuecomment-1217816080 Just a rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] Yikun commented on pull request #36353: [SPARK-38946][PYTHON][PS] Generates a new dataframe instead of operating inplace in setitem

Yikun commented on PR #36353: URL: https://github.com/apache/spark/pull/36353#issuecomment-1211914202 @HyukjinKwon Mind to take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] Yikun commented on pull request #36353: [SPARK-38946][PYTHON][PS] Generates a new dataframe instead of operating inplace in setitem

Yikun commented on PR #36353: URL: https://github.com/apache/spark/pull/36353#issuecomment-1211460815 @ueshin Thanks for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] Yikun commented on pull request #36353: [SPARK-38946][PYTHON][PS] Generates a new dataframe instead of operating inplace in setitem

Yikun commented on PR #36353: URL: https://github.com/apache/spark/pull/36353#issuecomment-1209973469 All test passed and Test passed with Pandas 1.4.2: https://github.com/Yikun/spark/pull/148 Test passed with Pandas 1.4.3: https://github.com/Yikun/spark/pull/147

[GitHub] [spark] Yikun commented on pull request #36353: [SPARK-38946][PYTHON][PS] Generates a new dataframe instead of operating inplace in setitem

Yikun commented on PR #36353: URL: https://github.com/apache/spark/pull/36353#issuecomment-1183864465 just a rebase, because we update numpy version in infra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] Yikun commented on pull request #36353: [SPARK-38946][PYTHON][PS] Generates a new dataframe instead of operating inplace in setitem

Yikun commented on PR #36353: URL: https://github.com/apache/spark/pull/36353#issuecomment-1178956945 Let me do a brief conclusion to help review: - **Change `setitem` to make a copy**https://github.com/pandas-dev/pandas/commit/03dd698bc1e84c35aba8b51bdd45c472860b9ec3 dataframe.setitem

[GitHub] [spark] Yikun commented on pull request #36353: [SPARK-38946][PYTHON][PS] Generates a new dataframe instead of operating inplace in setitem

Yikun commented on PR #36353: URL: https://github.com/apache/spark/pull/36353#issuecomment-1165688386 @ueshin ready for review, it would be good if you could find some time. : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] Yikun commented on pull request #36353: [SPARK-38946][PYTHON][PS] Generates a new dataframe instead of operating inplace in setitem

Yikun commented on PR #36353: URL: https://github.com/apache/spark/pull/36353#issuecomment-1164343056 According to https://github.com/pandas-dev/pandas/issues/47188 and https://github.com/pandas-dev/pandas/issues/47449 , we should only address `set_item` in here, so just skip test for