Yikun commented on PR #37117: URL: https://github.com/apache/spark/pull/37117#issuecomment-1178769601
@bzhaoopenstack Thanks for contributions! 1. Rename `[SPARK-39714][python]` to `[SPARK-39714][PYTHON]` : ) 2. It would be good you can fullfill the PR description even this is a minor fix ``` ./dev/lint-python // ...... starting mypy annotations test... annotations failed mypy checks: python/pyspark/pandas/indexes/base.py:48: error: Module "pandas._libs" has no attribute "lib" [attr-defined] python/pyspark/streaming/context.py:372: error: Unused "type: ignore" comment python/pyspark/streaming/context.py:378: error: Unused "type: ignore" comment Found 3 errors in 2 files (checked 338 source files) 1 (venv) ➜ spark git:(pr/37117) mypy --version mypy 0.941 ``` In my env, maybe also fix these? Could you also take a look? lint CI are using [mypy==0.920](https://github.com/bzhaoopenstack/spark/runs/7246817397?check_suite_focus=true#step:9:22) I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
