[GitHub] [spark] advancedxy commented on pull request #34602: [SPARK-37328][SQL] Fix bug that OptimizeSkewedJoin may not work after it was moved from queryStageOptimizerRules to queryStagePreparationR

2021-11-17 Thread GitBox
advancedxy commented on pull request #34602: URL: https://github.com/apache/spark/pull/34602#issuecomment-972467788 > It seems to me that the check if (shuffleStages.length == 2) is uncessary. aslo cc @JkSelf @ulysses-you per my understanding, it's mostly about to reduce complexity.

[GitHub] [spark] advancedxy commented on pull request #34602: [SPARK-37328][SQL] Fix bug that OptimizeSkewedJoin may not work after it was moved from queryStageOptimizerRules to queryStagePreparationR

2021-11-16 Thread GitBox
advancedxy commented on pull request #34602: URL: https://github.com/apache/spark/pull/34602#issuecomment-971322018 > `OptimizeSkewedJoin` is supposed to only handle materialized shuffle stages, or did I miss something? Hi @cloud-fan, `OptimizeSkewedJoin` is supposed to handle materi

[GitHub] [spark] advancedxy commented on pull request #34602: [SPARK-37328][SQL] Fix bug that OptimizeSkewedJoin may not work after it was moved from queryStageOptimizerRules to queryStagePreparationR

2021-11-15 Thread GitBox
advancedxy commented on pull request #34602: URL: https://github.com/apache/spark/pull/34602#issuecomment-969683745 ping @cloud-fan and @ulysses-you, could you take a look at this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log