ajithme commented on issue #27042: [SPARK-30382][SQL] Remove Hive LogUtils usage to prevent ClassNotFoundException URL: https://github.com/apache/spark/pull/27042#issuecomment-571477332 > Hi, @ajithme . Thank you for your contribution. I have two comments. > > 1. This PR fixes only Hive 2.3 code path. We need to remove Hive 1.2 code path. We want to keep both source code path identical as much as possible. > > ``` > $ git grep 'org.apache.hadoop.hive.common.LogUtils' > sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/server/HiveServer2.java:import org.apache.hadoop.hive.common.LogUtils; > sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/server/HiveServer2.java:import org.apache.hadoop.hive.common.LogUtils.LogInitializationException; > sql/hive-thriftserver/v2.3/src/main/java/org/apache/hive/service/server/HiveServer2.java:import org.apache.hadoop.hive.common.LogUtils; > sql/hive-thriftserver/v2.3/src/main/java/org/apache/hive/service/server/HiveServer2.java:import org.apache.hadoop.hive.common.LogUtils.LogInitializationException; > ``` > > 1. It would be better describe your PR's content in the PR title. You don't need to copy the JIRA title. I updated a little for you at this time. Also, I updated the PR description, too. @dongjoon-hyun Thanks for the inputs. I have updated the PR to Handle for Hive 1.2. Also thanks for updating PR details, will keep in mind next time.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
