[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-06-06 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-640098574 @srowen : Gentle reminder, kindly take a look when you get a chance. Thanks. This is an automated message from

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-06-02 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-637383391 Thanks, @Ngone51 for reviewing. CC: @srowen @jiangxb1987 @prakharjain09 Could you kindly help in reviewing this PR?

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-30 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-636297032 @Ngone51 Gentle reminder, I have refactored as suggested, please review when you get a chance. Thanks! This

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-21 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-632003872 @Ngone51 @jiangxb1987 Gentle ping, I have addressed your comments. Please review when you get a chance. Thanks.

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-03 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-623144460 > Oh, is there any simple test that can be added to verify it waits? I couldn't add any tests since the pollAndReportStatus method has System.exit() calls. Please let me

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-01 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-622331662 > I'm not that familiar with standalone mode, so assume we would like to make it behave similar with yarn-cluster. > > How it behaves if supervise option is specified?

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-01 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-622331206 @srowen Thanks for reviewing. I have addressed your comment. Kindly review it and please let me know your comments.

[GitHub] [spark] akshatb1 commented on pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-04-27 Thread GitBox
akshatb1 commented on pull request #28258: URL: https://github.com/apache/spark/pull/28258#issuecomment-620066867 Could someone kindly review these changes? CC: @cloud-fan @srowen @Ngone51 @HeartSaVioR This is an